feat(CVP-4331): add check-payload tool #331
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 18
Lines ? 502
Branches ? 0
========================================
Hits ? 502
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
yashvardhannanavati
force-pushed
the
unreleased_bundle
branch
from
8cc5dbf to
5449ae6
Compare
dirgim
requested review from
14rcole,
Josh-Everett,
dirgim,
hongweiliu17,
kasemAlem,
dheerajodha,
sonam1412,
jsztuka and
jencull
|
@yashvardhannanavati I have reservations about including a go utility into this image which is not geared towards such builds, would you consider having a separate image with which utilizes a supported go builder image instead? |
|
Including also @ralphbean for your opinion on how to include this tool in a best-practice manner. |
Yes, that makes sense. I'll check it out. Thank you! |
yashvardhannanavati
force-pushed
the
unreleased_bundle
branch
6 times, most recently
from
9f76aef to
b2b4097
Compare
|
ADR https://konflux-ci.dev/architecture/ADR/0046-common-task-runner-image.html hints at moving towards a common runner image. So, building a separate image for check-payload wouldn't be the right direction as it would introduce overhead in the near future. After a conversation with @dirgim , we decided to have a separate stage to build the check-payload tool so we can alleviate the concerns pointed out in his previous comment. |
yashvardhannanavati
force-pushed
the
unreleased_bundle
branch
5 times, most recently
from
b3413e3 to
0329867
Compare
Signed-off-by: Yashvardhan Nanavati <[email protected]>
yashvardhannanavati
force-pushed
the
unreleased_bundle
branch
from
0329867 to
42d07ab
Compare
|
|
||
| ARG CHECK_PAYLOAD_VERSION=0.3.2 | ||
|
|
||
| RUN curl -k -s -L -o check-payload.tar.gz "https://github.com/openshift/check-payload/archive/refs/tags/${CHECK_PAYLOAD_VERSION}.tar.gz" && \ |
There was a problem hiding this comment.
I do not think that curl -k should be used to download data from GitHub. -k means --insecure.
No description provided.